Skip to content

Fe/feature/ri 7231 replace eui unify components style #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 167 commits into
base: main
Choose a base branch
from

Conversation

pd-redis
Copy link
Collaborator

Rearrange and Rename Base Components (RI-7231)

Summary

This PR reorganizes and renames custom components in the base directory to improve consistency and maintainability. The implementation standardizes naming conventions and export patterns across the codebase.

Changes

  • Renamed components with consistent 'Ri' prefix (e.g., RiText, RiPopover, RiTooltip)
  • Reorganized directory structure for better component categorization
  • Updated exports from base components (layout, text, tooltip, shared, popover, link)
  • Added GlobalStyle theme component for consistent theming and CSS variables
  • Standardized styling approach using styled-components
  • Updated component imports across the application to use the new structure
  • Fixed tests to accommodate the renamed components

Why

This change improves code organization and maintainability by:

  • Establishing consistent naming conventions for custom components
  • Creating a more intuitive directory structure
  • Centralizing theme variables through GlobalStyle
  • Making component imports more consistent throughout the application

Testing

  • Updated and fixed affected tests to work with the renamed components
  • Verified that all components render correctly with the new structure

pd-redis added 30 commits May 7, 2025 12:28
# Conflicts:
#	redisinsight/ui/src/components/connectivity-error/ConnectivityError.tsx
#	redisinsight/ui/src/components/inline-item-editor/InlineItemEditor.tsx
#	redisinsight/ui/src/components/item-list/components/delete-action/DeleteAction.tsx
#	redisinsight/ui/src/components/item-list/components/export-action/ExportAction.tsx
#	redisinsight/ui/src/components/query/query-actions/QueryActions.tsx
#	redisinsight/ui/src/components/query/query-card/QueryCardHeader/QueryCardHeader.tsx
#	redisinsight/ui/src/components/side-panels/panels/enablement-area/EnablementArea/components/InternalPage/InternalPage.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyHash/AddKeyHash.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyList/AddKeyList.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyReJSON/AddKeyReJSON.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeySet/AddKeySet.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyStream/AddKeyStream.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyString/AddKeyString.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyZset/AddKeyZset.tsx
#	redisinsight/ui/src/pages/browser/modules/key-details/components/rejson-details/components/edit-entire-item-action/EditEntireItemAction.tsx
#	redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/add-set-members/AddSetMembers.tsx
#	redisinsight/ui/src/pages/database-analysis/components/header/Header.tsx
#	redisinsight/ui/src/pages/home/components/database-list-header/DatabaseListHeader.tsx
#	redisinsight/ui/src/pages/home/components/database-manage-tags-modal/ManageTagsModal.tsx
#	redisinsight/ui/src/pages/settings/components/cloud-settings/CloudSettings.tsx
#	redisinsight/ui/src/pages/settings/components/cloud-settings/components/user-api-keys-table/UserApiKeysTable.tsx
#	redisinsight/ui/src/pages/slow-log/components/Actions/Actions.tsx
pd-redis and others added 30 commits July 31, 2025 15:31
* add AppNavigation.tsx

* add useNavigation.ts, move AppNavigation to InstancePageTemplate.tsx
* replace the accordion component; change some styling to look nice with the accordion
* replace button group component
* import the modal components

* apply the form dialog; vefiry for the database connection form; delete unneeded styles

* replace filter key type modal

* remove filter key type eui styles

* replace browser search panel / module not loaded

* replace consents settings popup modal

* replace rdi import modal(s)

* add ids to buttons

* replace the start rdi pipeline modal

* remove background colors

* remove :global styling

* remove the advantages background

* replace select account dialog modal

* replace select plan modal

* replace oauth sso dialog modal

* finalize form dialog and manage tags modal

* round up the width, set too 601 for no reason (:

* format form dialog file

* use width modal prop instead of as part of the class

* fix the rebase issues - use the propper RI file picker

* and fix the upload warning container

* refactor size capital to small letter; format

* change rdi error configuration file icon and add color; align items

* return the exported type and format file

* use cx when multiple classes applied

* fix some of the tests failing due to issues with the modal header; skip the ones that are tied directly to the header as the header is set to null

* fix upload dialog tests

* fix database panel dialog

* change oauth sso dialog and browser search panel dialog to null

* fix width

* remove duplicate styling

* remove not needed code

* fix oauth select account dialog

* fix all tests regarding the buggy modal title

* reverting changes to the features config.json

---------

Co-authored-by: Kristiyan Ivanov <[email protected]>
…d the implementation around the main content under the new navigation (#4784)

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - added border above the new navigation

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - updated main content brackgrounds to use the proper colors

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - added borders to the keys list and key details to mimic the new DS

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - removed background for the bottom buttons (add, cancel, save, etc). In the new DS there is no different BG and it only makes it mroe complciated to keep track

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - add padding on top of the search bar to distance it from the new navigation

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - updated the cli row to look like the previews

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - updated spacing under the navigation to be handled in one place

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - fixed paddings for the CLI row

* RI-7269 - Fix major discrepancies between the DS previews and the implementation around the main content under the new navigation - Updated uses of theme to be through useTheme, instead of a direct import
* create loading logo component

* move import from layout to display

* add sizing to the component

* use $ for size and bounceSpeed instead of Omit

* implement redis theme sizing

* Rename folder logo-loading -> loading-logo

* create and export RiEmptyPrompt component

* replace the eui component with the new one

* Include the ...rest in the empty prompt component

* Extended spacer to support theme sizes

---------

Co-authored-by: Kristiyan Ivanov <[email protected]>
* RI-7244 -Edit-and-remove-buttons-are-not-aligned

* Update redisinsight/ui/src/components/base/forms/buttons/EmptyButton.tsx

Co-authored-by: pd-redis <[email protected]>

* Update redisinsight/ui/src/components/base/forms/buttons/EmptyButton.tsx

Co-authored-by: pd-redis <[email protected]>

---------

Co-authored-by: pd-redis <[email protected]>
* provide actual icon element to IconButton

* set LikeIcon as default for VoteOption.tsx
* RI-7252 - RDI---Broken-layout-for-the-list-of-jobs - added size props for the inline item editor's action section

* RI-7252 - RDI---Broken-layout-for-the-list-of-jobs - added size props for the inline item editor's action section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants